Messages in this thread | | | From | Kumar Gala <> | Subject | Re: [PATCH 1/7] Copy mpc-i2c to preserve support for ARCH=ppc and allow changes on ARCH=powerpc | Date | Tue, 18 Dec 2007 09:53:28 -0600 |
| |
On Dec 17, 2007, at 8:39 PM, Jon Smirl wrote:
> Temporarily copy the mpc-i2c driver to continue support for the ppc > architecture until it is removed in mid-2008. This file should be > deleted as part of ppc's final removal. > > Signed-off-by: Jon Smirl <jonsmirl@gmail.com> > > Signed-off-by: Jon Smirl <jonsmirl@gmail.com> > > Signed-off-by: Jon Smirl <jonsmirl@gmail.com> > --- > > arch/ppc/configs/TQM8540_defconfig | 2 > arch/ppc/configs/TQM8541_defconfig | 2 > arch/ppc/configs/TQM8555_defconfig | 2 > arch/ppc/configs/TQM8560_defconfig | 2 > arch/ppc/configs/mpc834x_sys_defconfig | 2 > arch/ppc/configs/mpc8540_ads_defconfig | 2 > arch/ppc/configs/mpc8548_cds_defconfig | 2 > arch/ppc/configs/mpc8555_cds_defconfig | 2 > arch/ppc/configs/mpc8560_ads_defconfig | 2 > drivers/i2c/busses/Kconfig | 16 + > drivers/i2c/busses/Makefile | 1 > drivers/i2c/busses/i2c-mpc-ppc.c | 418 +++++++++++++++++++++++ > +++++++++ > 12 files changed, 443 insertions(+), 10 deletions(-) > create mode 100644 drivers/i2c/busses/i2c-mpc-ppc.c
Nak.
Just ifdef the probe functionality in i2c-mpc.c based on CONFIG_PPC_MERGE. Your patch set shows the reason you should do this. You provide fixes to the error path handling, but only for i2c- mpc.c and not i2c-mpc-ppc.c.
- k
| |