Messages in this thread | | | Date | Tue, 18 Dec 2007 16:22:59 -0600 | From | Matt Mackall <> | Subject | Re: [PATCH] procfs : Move some extern declaration from fs/proc/proc_misc.c to include/linux/seq_file.h |
| |
On Tue, Dec 18, 2007 at 10:25:50PM +0100, Eric Dumazet wrote: > Some 'extern struct seq_operations' are wrongly defined in > fs/proc/proc_misc.c (they miss a const qualifier) > > In order to fix this correctly, move the "extern ... " declaration from .c > file to an appropriate include file, as advised by checkpatch.pl > > Note : "extern struct seq_operations cpuinfo_op;" will be taken into account > in a separate patch, since its const status is arch dependant.
seq_file.h doesn't seem the best place for these, as it's otherwise unpolluted with anything but seq_file internals.
Most of these things perhaps ought to be pushed out to their relevant subsystems and then no .h file declaration will be needed.
-- Mathematics is the supreme nostalgia of our time.
| |