lkml.org 
[lkml]   [2007]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] procfs : Move some extern declaration from fs/proc/proc_misc.c to include/linux/seq_file.h
On Tue, Dec 18, 2007 at 10:25:50PM +0100, Eric Dumazet wrote:
> Some 'extern struct seq_operations' are wrongly defined in
> fs/proc/proc_misc.c (they miss a const qualifier)
>
> In order to fix this correctly, move the "extern ... " declaration from .c
> file to an appropriate include file, as advised by checkpatch.pl
>
> Note : "extern struct seq_operations cpuinfo_op;" will be taken into account
> in a separate patch, since its const status is arch dependant.

seq_file.h doesn't seem the best place for these, as it's otherwise
unpolluted with anything but seq_file internals.

Most of these things perhaps ought to be pushed out to their relevant
subsystems and then no .h file declaration will be needed.

--
Mathematics is the supreme nostalgia of our time.


\
 
 \ /
  Last update: 2007-12-18 23:27    [W:0.083 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site