Messages in this thread | | | From | Frans Pop <> | Subject | Re: [PATCH] finish processor.h integration | Date | Tue, 18 Dec 2007 22:32:43 +0100 |
| |
On Tuesday 18 December 2007, Glauber de Oliveira Costa wrote: > On Dec 18, 2007 6:54 PM, Frans Pop <elendil@planet.nl> wrote: > > Glauber de Oliveira Costa wrote: > > > What's left in processor_32.h and processor_64.h cannot be cleanly > > > integrated. However, it's just a couple of definitions. They are > > > moved to processor.h around ifdefs, and the original files are > > > deleted. Note that there's much less headers included in the final > > > version. > > > > Either I must be missing something or this patch was corrupted somehow. > > neither. > Note the else in the middle. It's just a mistake in the comment.
Wouldn't an explicit second #ifdef block be a lot clearer (and improve maintainability) in this case?
An #else can easily be overlooked among other preprocessor commands or when #ifdefs get nested.
| |