Messages in this thread | | | Subject | Re: [RFC/PATCH 2/8] revoke: inode revoke lock V7 | From | (Jonathan Corbet) | Date | Tue, 18 Dec 2007 09:31:49 -0700 |
| |
This is a relatively minor detail in the rather bigger context of this patch, but...
> @@ -642,6 +644,7 @@ struct inode { > struct list_head inotify_watches; /* watches on this inode */ > struct mutex inotify_mutex; /* protects the watches list */ > #endif > + wait_queue_head_t i_revoke_wait;
That seems like a relatively hefty addition to every inode in the system when revoke - I think - will be a fairly rare operation. Would there be any significant cost to using a single, global revoke-wait queue instead of growing the inode structure?
jon
| |