Messages in this thread | | | Date | Wed, 12 Dec 2007 23:11:56 -0800 | From | Greg KH <> | Subject | Re: [PATCH] kbuild: implement modules.order, take #2 |
| |
On Fri, Dec 07, 2007 at 09:04:30PM +0900, Tejun Heo wrote: > When multiple built-in modules (especially drivers) provide the same > capability, they're prioritized by link order specified by the order > listed in Makefile. This implicit ordering is lost for loadable > modules. > > When driver modules are loaded by udev, what comes first in > modules.alias file is selected. However, the order in this file is > indeterministic (depends on filesystem listing order of installed > modules). This causes confusion. > > The solution is two-parted. This patch updates kbuild such that it > generates and installs modules.order which contains the name of > modules ordered according to Makefile. The second part is update to > depmod such that it generates output files according to this file. > > Note that both obj-y and obj-m subdirs can contain modules and > ordering information between those two are lost from beginning. > Currently obj-y subdirs are put before obj-m subdirs. > > Sam Ravnborg cleaned up Makefile modifications and suggested using awk > to remove duplicate lines from modules.order instead of using separate > C program. > > Signed-off-by: Tejun Heo <htejun@gmail.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Bill Nottingham <notting@redhat.com> > Cc: Rusty Russell <rusty@rustcorp.com.au> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
thanks for doing this, looks very nice.
greg k-h
| |