lkml.org 
[lkml]   [2007]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modpost
    On Thu, Nov 22, 2007 at 03:43:10AM +0100, Andi Kleen wrote:
    >
    > When passing an file name > 1k the stack could be overflowed.
    > Not really a security issue, but still better plugged.

    Looks good. A s-o-b line again please.
    Although I am not so happy with the ue of gcc extensions.

    Sam
    >
    >
    > ---
    > scripts/mod/modpost.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > Index: linux/scripts/mod/modpost.c
    > ===================================================================
    > --- linux.orig/scripts/mod/modpost.c
    > +++ linux/scripts/mod/modpost.c
    > @@ -1656,7 +1656,6 @@ int main(int argc, char **argv)
    > {
    > struct module *mod;
    > struct buffer buf = { };
    > - char fname[SZ];
    > char *kernel_read = NULL, *module_read = NULL;
    > char *dump_write = NULL;
    > int opt;
    > @@ -1709,6 +1708,8 @@ int main(int argc, char **argv)
    > err = 0;
    >
    > for (mod = modules; mod; mod = mod->next) {
    > + char fname[strlen(mod->name) + 10];
    > +
    > if (mod->skip)
    > continue;
    >


    \
     
     \ /
      Last update: 2007-12-10 20:33    [W:4.243 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site