Messages in this thread | | | From | Akio Takebe <> | Subject | Re: [kvm-devel] include files for kvmclock | Date | Wed, 07 Nov 2007 17:16:37 +0900 |
| |
Hi, Glauber
This is interesting facility. :-)
>+#define KVM_HCALL_REGISTER_CLOCK 1 >+ >+union kvm_hv_clock { >+ struct { >+ u64 tsc_mult; >+ u64 now_ns; >+ /* That's the wall clock, not the water closet */ >+ u64 wc_sec; >+ u64 wc_nsec; >+ u64 last_tsc; >+ /* At first, we could use the tsc value as a marker, but Jeremy >+ * well noted that it will cause us locking problems in 32-bit >+ * sys, so we have a special version field */ >+ u32 version; >+ }; >+ char page_align[PAGE_SIZE]; >+}; >+ Why does kvm_hv_clock need page_align? And also the kvm_hv_clock is alloced with kvm_vcpu, so the align is not enough, isn't it? I thik __atribute__((__aligne__(PAGE_SIZE)))) is better than it.
Best Regards,
Akio Takebe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |