lkml.org 
[lkml]   [2007]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [kvm-devel] include files for kvmclock
Date
Hi, Glauber

This is interesting facility. :-)

>+#define KVM_HCALL_REGISTER_CLOCK 1
>+
>+union kvm_hv_clock {
>+ struct {
>+ u64 tsc_mult;
>+ u64 now_ns;
>+ /* That's the wall clock, not the water closet */
>+ u64 wc_sec;
>+ u64 wc_nsec;
>+ u64 last_tsc;
>+ /* At first, we could use the tsc value as a marker, but Jeremy
>+ * well noted that it will cause us locking problems in 32-bit
>+ * sys, so we have a special version field */
>+ u32 version;
>+ };
>+ char page_align[PAGE_SIZE];
>+};
>+
Why does kvm_hv_clock need page_align?
And also the kvm_hv_clock is alloced with kvm_vcpu,
so the align is not enough, isn't it?
I thik __atribute__((__aligne__(PAGE_SIZE)))) is better than it.

Best Regards,

Akio Takebe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-07 09:21    [W:2.958 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site