Messages in this thread | | | Date | Wed, 07 Nov 2007 18:23:42 -0500 | From | Mark Lord <> | Subject | Re: [PATCH] r8169 fix regression on ASUS motherboards (updated) |
| |
Francois Romieu wrote: > Mark Lord <lkml@rtr.ca> : >> Mark Lord wrote: >>> Francois Romieu wrote: >>> .. >>>> I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12 >>>> too, namely XID = 0x38000000. >> .. >> >> Here is the updated patch for both VER_11 and VER_12. >> Let's get this in, as the driver has been broken for weeks now. > > I have not been waiting for you and I am not interested in your > controversy. > > I'll find the offending commit and revert it. It is that simple. ..
I think the rest of the commit was fine -- there seems to be some nice cleanups there to make it easier to maintain.
Just the new register writes (rtl8168b_hw_phy_config()) are mucking things up. Prevent those from happening, and all is well.
Cheers
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |