Messages in this thread | | | Date | Wed, 07 Nov 2007 17:21:29 -0500 | From | Mark Lord <> | Subject | Re: [PATCH] r8169 fix regression on ASUS motherboards |
| |
Francois Romieu wrote: > Mark Lord <lkml@rtr.ca> : >> Fix r8169 regression on ASUS motherboards. >> >> The r8169 ethernet driver worked fine in 2.6.23, but fails >> in 2.6.24-rc* for the onboard ethernet of ASUS P5B series motherboards. >> This patch fixes it again. > [...] >> --- broken/drivers/net/r8169.c 2007-11-07 12:32:29.000000000 -0500 >> +++ linux/drivers/net/r8169.c 2007-11-07 12:55:07.000000000 -0500 >> @@ -1325,6 +1325,7 @@ >> rtl8169sb_hw_phy_config(ioaddr); >> break; >> case RTL_GIGA_MAC_VER_11: >> + break; >> case RTL_GIGA_MAC_VER_12: >> case RTL_GIGA_MAC_VER_17: >> rtl8168b_hw_phy_config(ioaddr); > > I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12 > too, namely XID = 0x38000000. ..
Tested and working here on VER_11. I don't have a VER_12, so I left that as-is. If you want to fix that as well, just move the new "break;" down one line.
The rest of the broken commit works fine without the new call to rtl8168b_hw_phy_config(ioaddr).
It's been weeks now, so please FIX it now.
Thanks.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |