lkml.org 
[lkml]   [2007]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 09/23] SLUB: Add get() and kick() methods
On Tue, Nov 06, 2007 at 07:07:15PM -0800, Christoph Lameter wrote:
> On Wed, 7 Nov 2007, Adrian Bunk wrote:
>
> > A static inline dummy function for CONFIG_SLUB=n seems to be missing?
>
> Correct. This patch is needed so that building with SLAB will work.
>
> Slab defrag: Provide empty kmem_cache_setup_defrag function for SLAB.
>
> Provide an empty function to satisfy dependencies for Slab defrag.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>?
>
> ---
> mm/slab.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> Index: linux-2.6/mm/slab.c
> ===================================================================
> --- linux-2.6.orig/mm/slab.c 2007-11-06 18:57:22.000000000 -0800
> +++ linux-2.6/mm/slab.c 2007-11-06 18:58:40.000000000 -0800
> @@ -2535,6 +2535,13 @@ static int __cache_shrink(struct kmem_ca
> return (ret ? 1 : 0);
> }
>
> +void kmem_cache_setup_defrag(struct kmem_cache *s,
> + void *(*get)(struct kmem_cache *, int nr, void **),
> + void (*kick)(struct kmem_cache *, int nr, void **, void *private))
> +{
> +}
> +EXPORT_SYMBOL(kmem_cache_setup_defrag);
> +

- this misses slob
- this wastes memory

An empty static inline function in slab.h would be better.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-07 04:29    [W:0.048 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site