Messages in this thread | | | Date | Fri, 30 Nov 2007 13:07:19 -0800 | From | Greg KH <> | Subject | Re: [RFC] kobject: add kobject_init_ng and kobject_init_and_add functions |
| |
On Fri, Nov 30, 2007 at 01:04:20PM -0800, Greg KH wrote: > > My suggestion: Have kobject_init_ng() accept a ktype pointer but not a > > parent or name. Instead, make kobject_add_ng() take the parent and > > name (possibly a kset also). Then when kobject_init_and_add() > > encounters an error, it shouldn't do a _put() -- the caller can either > > do the _put() or just do a kfree(). > > Why not the parent for init()? Isn't it always known at that time? > I'll dig to be sure.
You are right again, to match up with the driver core methods, we don't know the parent until add() time.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |