lkml.org 
[lkml]   [2007]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: named + capset = EPERM [Was: 2.6.24-rc3-mm2]
On 11/29/2007 01:17 AM, Serge E. Hallyn wrote:
> From 70d5da610fdbd66a36886c01e27b7fb11d2de044 Mon Sep 17 00:00:00 2001
> From: sergeh@us.ibm.com <hallyn@kernel.(none)>
> Date: Wed, 28 Nov 2007 16:16:23 -0800
> Subject: [PATCH 1/1] capabilities: correct logic at capset_check
>
> Fix typo at capset_check introduced with capability bounding set
> patch.
>
> Signed-off-by: sergeh@us.ibm.com <hallyn@kernel.(none)>

Tested-by: Jiri Slaby <jirislaby@gmail.com>

> ---
> security/commoncap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/security/commoncap.c b/security/commoncap.c
> index c25ad09..503e958 100644
> --- a/security/commoncap.c
> +++ b/security/commoncap.c
> @@ -119,7 +119,7 @@ int cap_capset_check (struct task_struct *target, kernel_cap_t *effective,
> /* incapable of using this inheritable set */
> return -EPERM;
> }
> - if (!!cap_issubset(*inheritable,
> + if (!cap_issubset(*inheritable,
> cap_combine(target->cap_inheritable,
> current->cap_bset))) {
> /* no new pI capabilities outside bounding set */

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-29 23:59    [W:2.085 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site