lkml.org 
[lkml]   [2007]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: broken dpt_i2o in 2.6.23 (was: ext2_check_page: bad entry in directory) (fwd)
    On Nov 29 2007, FUJITA Tomonori wrote:
    > On Thu, 29 Nov 2007 14:03:19 +0100
    > Jan Kara <jack@ucw.cz> wrote:
    >
    > > Adding relevant people and lists to CC...
    > >
    > > Honza
    > >
    > > ----- Forwarded message from Anders Henke <anders.henke@1und1.de> -----
    > >
    > > Date: Thu, 29 Nov 2007 13:31:50 +0100
    > > From: Anders Henke <anders.henke@1und1.de>
    > > To: linux-kernel@vger.kernel.org
    > > Subject: Re: broken dpt_i2o in 2.6.23 (was: ext2_check_page: bad entry in directory)
    > > User-Agent: Mutt/1.5.13 (2006-08-11)
    > >
    > > On November 28 2007, Anders Henke wrote:
    > > > As "everything is reported as being zero" is quite odd an Jan took a
    > > > guess that it might be block-layer or driver-related, I've assumed
    > > > that the driver is responsible for this; just out of the curiousity,
    > > > I've manually replaced the dpt_i2o driver by the 2.6.19 one by copying
    > > > driver/scsi/dpt_i2o.c driver/scsi/dpti.h and driver/scsi/dpt/ into a
    > > > vanilla 2.6.23.1. kernel; using this kernel fixed the issue for me.
    > > >
    > > > I haven't yet fine-tested from which kernel release on the dpt_i2o driver
    > > > behaves like this and spews out zeroed blocks when trying to mount
    > > > the rootfs. Maybe this is just some timing issue.
    > >
    > > I've started the fine-tests and can say so far that dpt_i2o from
    > > 2.6.22 is still fine. Test is simple:
    > >
    > > anders@ista:/usr/src/linux-2.6.22/drivers/scsi/dpt$ cp -r dpt/ dpt_i2o.c dpti.h /usr/src/linux-2.6.23.1/drivers/scsi/
    > >
    > > ... recompile the kernel, reboot: works.
    > >
    > > 2.6.22 and 2.6.23 differ in terms of the dpt_i2o driver by two different
    > > patch sets:
    > > -one 2 Kb small set of patches from 2.6.22 to 2.6.22-rc1
    > > -one 7 Kb set of patches from 2.6.23-rc2 to 2.6.23-rc3
    > > -one 162 Kb set of patches from 2.6.23-rc9 to 2.6.23-rc10.
    > >
    > > When applying the 2.6.23-rc1-based driver to "my" 2.6.31.1 kernel,
    > > the "zero blocks"-symptom show up, so it's the "lucky" situation
    > > that the smallest patch actually seams to be the broken one.
    > >
    > > According to the 2.6.23-rc1 short-form changelog, there is
    > > one major edit on the dpt_i2o driver:
    > >
    > > FUJITA Tomonori
    > >
    > > [SCSI] dpt_i2o: convert to use the data buffer accessors
    > >
    > > Stephen Rothwell
    > > dpt_i2o depends on virt_to_bus
    > >
    > > Fujita, would you please take a look at this?
    >
    > Sorry about the bug. Can you try this?
    >
    >
    > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
    > index 8258506..1255b26 100644
    > --- a/drivers/scsi/dpt_i2o.c
    > +++ b/drivers/scsi/dpt_i2o.c
    > @@ -3295,7 +3295,7 @@ static struct scsi_host_template adpt_template = {
    > .this_id = 7,
    > .cmd_per_lun = 1,
    > .use_clustering = ENABLE_CLUSTERING,
    > - .use_sg_chaining = ENABLE_SG_CHAINING,
    > + .use_sg_chaining = DISABLE_SG_CHAINING,
    > };
    >
    > static s32 adpt_scsi_register(adpt_hba* pHba)

    The structure to patch does look different and doesn't include an
    tag "use_sg_chaining":

    ---cut
    static struct scsi_host_template adpt_template = {
    .name = "dpt_i2o",
    .proc_name = "dpt_i2o",
    .proc_info = adpt_proc_info,
    .info = adpt_info,
    .queuecommand = adpt_queue,
    .eh_abort_handler = adpt_abort,
    .eh_device_reset_handler = adpt_device_reset,
    .eh_bus_reset_handler = adpt_bus_reset,
    .eh_host_reset_handler = adpt_reset,
    .bios_param = adpt_bios_param,
    .slave_configure = adpt_slave_configure,
    .can_queue = MAX_TO_IOP_MESSAGES,
    .this_id = 7,
    .cmd_per_lun = 1,
    .use_clustering = ENABLE_CLUSTERING,
    };

    static s32 adpt_scsi_register(adpt_hba* pHba)
    ---cut



    Anders
    --
    1&1 Internet AG System Design
    Brauerstrasse 48 v://49.721.91374.50
    D-76135 Karlsruhe f://49.721.91374.225

    Amtsgericht Montabaur HRB 6484
    Vorstand: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Andreas Gauger,
    Thomas Gottschlich, Matthias Greve, Robert Hoffmann, Norbert Lang, Achim Weiss
    Aufsichtsratsvorsitzender: Michael Scheeren
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-29 17:49    [W:4.159 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site