Messages in this thread | | | Date | Wed, 28 Nov 2007 18:08:16 +0100 (CET) | From | Roman Zippel <> | Subject | Re: [PATCH] kconfig: Make KCONFIG_ALLCONFIG work with randconfig. |
| |
Hi,
On Wed, 28 Nov 2007, Paul Mundt wrote:
> Adrian mentioned a few weeks ago that KCONFIG_ALLCONFIG is the way to > go to ensure that things like allyes/allmod/allnoconfig work with a > constrained set of symbols, with the implication that this holds > true for randconfig as well.
BTW another possibility is to use all{no,mod,yes,random,}.config.
> While allyes/mod/noconfigs do seem to work fine with KCONFIG_ALLCONFIG > provisions, randconfig tramples all over the provided values at perhaps > not surprisingly, random.
Please be careful with such broad statements, there is only an issue with choice values.
> Debugging this a bit, there seemed to be two issues: > > - SYMBOL_DEF and SYMBOL_DEF_USER overlap, which made > def_sym->flags the same regardless of whether we came from an > KCONFIG_ALLCONFIG path or not.
Look at how SYMBOL_DEF is used in confdata.c.
> - clobbering of the fixed value in conf_choice() by way of > random() def assignment.
Simply add a test for is_new there.
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |