Messages in this thread | | | Date | Tue, 27 Nov 2007 08:36:41 +0000 (GMT) | From | Hugh Dickins <> | Subject | Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations |
| |
On Mon, 26 Nov 2007, Andrew Morton wrote: > > It is peculair to (wrongly) return -ENOMEM > > > + if (shmem_reserve_inode(inode->i_sb)) > > + return -ENOSPC; > > and to then correct it in the caller..
Oops, I missed that completely.
> Something boringly conventional such as the below, perhaps?
Much better, thanks.
Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |