Messages in this thread | | | Date | Mon, 26 Nov 2007 21:29:55 -0800 | From | Greg KH <> | Subject | Re: [PATCH] Add iSCSI IBFT Support (v0.3) |
| |
On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote: > On Monday 26 November 2007 22:31:38 Greg KH wrote: > > > +#if defined(CONFIG_ISCSI_IBFT) || defined(CONFIG_ISCSI_IBFT_MODULE) > ..snip.. > > > +static ssize_t find_ibft(void) > > > +{ > ..snip.. > > > +} > > > > What is a function (not even an inline one) doing in a .h file? > > I was not sure where to put it. This function (find_ibft) is used by the > setup_[32|64].c and the iscsi_ibft.c code. Randy suggested I put in .c file, > but I am not sure exactly where? Should I make a new file in called > libs/iscsi_ibft_helper.c ?
Put it in your .c file and make it a global function to be called by someone else if they need it.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |