Messages in this thread | | | Date | Tue, 27 Nov 2007 01:23:39 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 6/6] Hibernation: Move extern definition to header file |
| |
Hi!
> From: Rafael J. Wysocki <rjw@sisk.pl> > > Move the extern definition of resume_file[] from kernel/power/swap.c > to kernel/power/power.h . > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
can we just get rid of extern? It does not seem to be used. (at least in very quick grep over 2.6.24-rc3):
pavel@amd:/data/l/linux/kernel/power$ grep resume_file *.c disk.c:char resume_file[256] = CONFIG_PM_STD_PARTITION; disk.c: if (!strlen(resume_file)) { disk.c: swsusp_resume_device = name_to_dev_t(resume_file); disk.c: pr_debug("swsusp: Resume From Partition %s\n", resume_file); disk.c: strncpy( resume_file, str, 255 ); swap.c:extern char resume_file[]; pavel@amd:/data/l/linux/kernel/power$
Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |