Messages in this thread | | | Date | Fri, 23 Nov 2007 09:58:24 +0100 | From | Pierre Peiffer <> | Subject | Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace |
| |
Hi,
Thanks for reviewing this !
Pavel Emelyanov wrote: > Pavel Emelyanov wrote: >> Cedric Le Goater wrote: >>> Pierre Peiffer wrote: > > [snip] > >>> Pavel, what do you think of it ? >> Looks sane, good catch, Pierre. >> >> But I'd find out whether these three ipc_ids intersect any >> cache-line. In other words I'd mark the struct ipc_ids as >> ____cacheline_aligned and checked for any differences. > > BTW! It might be also useful to keep ipc_ids closer to their > sysctl parameters. >
It makes sense indeed.
That would mean to have something like this, right ?
struct ipc_namespace { struct kref kref;
struct ipc_ids sem_ids; int sem_ctls[4]; int used_sems;
struct ipc_ids msg_ids; int msg_ctlmax; int msg_ctlmnb; int msg_ctlmni; atomic_t msg_bytes; atomic_t msg_hdrs;
struct ipc_ids shm_ids; size_t shm_ctlmax; size_t shm_ctlall; int shm_ctlmni; int shm_tot; };
After a quick look, that implies to rework a little bit procfs... othwise, it's not a big deal as I can see.
P.
>>> Acked-by: Cedric Le Goater <clg@fr.ibm.com> >>> >>> Thanks, >> Thanks, >> Pavel >> >>> C. > > [snip] > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
-- Pierre Peiffer - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |