Messages in this thread Patch in this message | | | Date | Fri, 23 Nov 2007 21:48:51 +0300 | From | Evgeniy Polyakov <> | Subject | Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable() |
| |
On Fri, Nov 23, 2007 at 08:57:57PM +0300, Evgeniy Polyakov (johnpol@2ka.mipt.ru) wrote: > > My memory here is hazy, but I think this exists to rescue netconsole > > in low-memory situations. This bit originated with Ingo, so maybe he > > can recall. > > > > Netpoll can process an arbitrary number of skbs inside a single > > interrupt. Think sysrq-t at one packet per line or kgdboe where the > > entire trace session can happen inside one very long interrupt. > > > > Perhaps we can refine this to mark netpoll's skbs (perhaps with > > ->destructor?) and delete only skbs we own. As these are never passed > > through any of the other route/xfrm/filter code, they should be safe > > to delete even in irq context, yes? > > > > > Removing zap_completion_queue() from find_skb() will fix the warning, > > > but I'm not sure this is a correct fix. I've added Matt to the Cc list. > > > > Care to try the sysrq-t or OOM message tests? > > We basically can not free skbs there - if it is interrupt context and > we are freeing some skb with destructor we will catch the warning anyway. > > No matter if we are under memory pressure or whatever - it is not > allowed - a lot of skbs are supposed to be freed in softirq context, > that is why dev_kfree_skb_any() exists. > > I think we can drop skbs _without_ destructor from the queue though in > that conditions given that we actually need only one.
Stop, we are trying to free skb without destructor and catch connection tracking, so it is not a solution. To fix the problem we need to check if it is not netfilter related, kind of this (not tested), Simon please give it a try:
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 758dafe..855bb3f 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -196,7 +196,7 @@ static void zap_completion_queue(void) while (clist != NULL) { struct sk_buff *skb = clist; clist = clist->next; - if (skb->destructor) + if (skb->destructor || skb->nfct || skb->nfct_reasm) dev_kfree_skb_any(skb); /* put this one back */ else __kfree_skb(skb);
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |