Messages in this thread | | | Date | Fri, 23 Nov 2007 10:16:46 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH] PPC: CHRP - fix possible NULL pointer dereference |
| |
On Thu, 22 Nov 2007 22:54:23 +0300 Cyrill Gorcunov <gorcunov@gmail.com> wrote: > > This patch does fix possible NULL pointer dereference > inside of strncmp() if of_get_property() failed.
Thanks for this.
> static void __init sio_init(void) > { > struct device_node *root; > + const char *model = NULL;
You don't need this initialization as you always assign the variable before you use it.
> + root = of_find_node_by_path("/"); > + if (root) {
if (!root) return;
would save a level of indentation. Not important.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |