Messages in this thread | | | Date | Wed, 21 Nov 2007 11:06:33 -0800 | From | Zach Brown <> | Subject | Re: [PATCH]loop cleanup in fs/namespace.c - repost |
| |
> The patch given below replaces the goto-loop by a while-based one.
That certainly looks fine. I would also replace the 'return' with 'break', but I guess that's more of a question of personal preference.
> Besides, it removes the export for the same routine, because there are > no users for it outside of the core VFS code.
This doesn't look fine. Did you test this?
mntput_no_expire() is called from mntput() which is an inline function in mount.h. So lots of callers of mntput() in modules will end up trying to call mntput_no_expire() from modules.
$ nm fs/fuse/fuse.ko | grep mntput_no_expire U mntput_no_expire
- z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |