Messages in this thread | | | Subject | Re: [PATCH 2/5] x86: use get_desc_base | From | Zachary Amsden <> | Date | Wed, 21 Nov 2007 10:30:31 -0800 |
| |
On Wed, 2007-11-21 at 02:20 -0800, Roland McGrath wrote: > This changes a couple of places to use the get_desc_base function. > They were duplicating the same calculation with different equivalent code. > > Signed-off-by: Roland McGrath <roland@redhat.com> > > diff --git a/arch/x86/ia32/tls32.c b/arch/x86/ia32/tls32.c > index 1cc4340..5291596 100644 > --- a/arch/x86/ia32/tls32.c > +++ b/arch/x86/ia32/tls32.c > @@ -85,11 +85,6 @@ asmlinkage long sys32_set_thread_area(struct user_desc __user *u_info) > * Get the current Thread-Local Storage area: > */ > > -#define GET_BASE(desc) ( \ > - (((desc)->a >> 16) & 0x0000ffff) | \ > - (((desc)->b << 16) & 0x00ff0000) | \ > - ( (desc)->b & 0xff000000) )
Are you sure there still aren't more of these things floating around? I recall ptrace and process.c even having one at one point, hopefully they are all gone.
Nice cleanups,
Zach
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |