lkml.org 
[lkml]   [2007]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Use i8253.c lock for PC speaker on MIPS, too.


On Fri, 2 Nov 2007, Ralf Baechle wrote:
>
> The Jazz machines have to use the PIT timer for dyntick and highresolution
> kernels. This may break because currently just like i386 used to do MIPS
> uses two separate spinlocks in the actual PIT code and the PC speaker
> code. So switch to do it the same that x86 currently does PIT locking.

Hmm. That leaves apparently just alpha/ppc/powerpc as supporting pcspkr,
and *not* doing this. Maybe they should be forced to do the i8253 lock in
arch code too, and expose it through <asm/i8253.h>, instead of having that
butt-ugly #ifdef remain in the sources?

Paul, Jay, Ivan: right now drivers/input/pcspkr.c does this:

#if defined(CONFIG_MIPS) || defined(CONFIG_X86)
/* Use the global PIT lock ! */
#include <asm/i8253.h>
#else
#include <asm/8253pit.h>
static DEFINE_SPINLOCK(i8253_lock);
#endif

and wouldn't it be nice if we just changed it to

#include <asm/i8253.h>

and got rid of one totally unnecessary stupid arch difference?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-03 03:49    [W:0.052 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site