lkml.org 
[lkml]   [2007]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [perfmon] Re: [perfmon2] perfmon2 merge news
    David Miller writes:

    > As a result I've found that perfmon2 is quite nice and allows
    > incredibly useful and powerful tools to be written. The syscalls
    > aren't that bad and really I see not reason to block it's inclusion.
    >
    > I rescind all of my earlier objections, let's merge this soon :-)

    Strongly agree. However, I think we need to add structure size
    arguments to most of the syscalls so we can extend them later.

    Also, something I've been meaning to mention to Stephane is that the
    use of the cast_ulp() macro in perfmon is bogus and won't work on
    32-bit big-endian platforms such as ppc32 and sparc32. On such
    platforms you can't take a pointer to an array of u64, cast it to
    unsigned long * and expect the kernel bitmap operations to work
    correctly on it. At the least you also need to XOR the bit numbers
    with 32 on those platforms. Another alternative is to define the
    bitmaps as arrays of bytes instead, which eliminates all byte ordering
    and wordsize problems (but makes it more tricky to use the kernel
    bitmap functions directly).

    Paul.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-19 22:47    [W:3.185 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site