Messages in this thread | | | Subject | Re: [RFC 5/7] LTTng instrumentation mm | From | Dave Hansen <> | Date | Mon, 19 Nov 2007 11:43:58 -0800 |
| |
On Mon, 2007-11-19 at 14:00 -0500, Mathieu Desnoyers wrote: > > Well, using page_to_pfn turns out to be ugly in markers (and in > > printks) then. Depending on the architecture, it will result in either > > an unsigned long (x86_64) or an unsigned int (i386), which corresponds > > Well, it's signed long and signed int, but the point is still valid.
the result of page_to_pfn() may end up being signed in practice, but it never needs to be. Just cast it to an unsigned long and make it consistent everywhere.
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |