Messages in this thread | | | Date | Sat, 17 Nov 2007 11:38:55 +0100 | From | Jean Delvare <> | Subject | Re: [patch/rfc 1/4] GPIO implementation framework |
| |
On Tue, 13 Nov 2007 20:36:13 -0800, David Brownell wrote: > On Tuesday 13 November 2007, eric miao wrote: > > if (!requested) > > - printk(KERN_DEBUG "GPIO-%d autorequested\n", > > - chip->base + offset); > > + pr_debug("GPIO-%d autorequested\n", gpio); > > Leave the printk in ... this is the sort of thing we want > to see fixed, which becomes unlikely once you hide such > diagnostics. And for that matter, what would be enabling > the "-DDEBUG" that would trigger a pr_debug() message?
The original code isn't correct either. Either this is a debug message and indeed pr_debug() should be used, or it's not and KERN_DEBUG should be replaced by a lower log level.
-- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |