Messages in this thread Patch in this message | | | Date | Sat, 17 Nov 2007 20:50:14 -0400 | From | Kevin Winchester <> | Subject | Re: 2.6.24-rc2-mm1 -- strange apparent network failures |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Andrew Morgan wrote: > Kevin, > > Can you try this quick hack? > > diff --git a/kernel/capability.c b/kernel/capability.c > index e57d1aa..4088610 100644 > --- a/kernel/capability.c > +++ b/kernel/capability.c > @@ -109,7 +109,7 @@ out: > kdata[i].permitted = pP.cap[i]; > kdata[i].inheritable = pI.cap[i]; > } > - while (i < _LINUX_CAPABILITY_U32S) { > + while (0 && (i < _LINUX_CAPABILITY_U32S)) { > if (pE.cap[i] || pP.cap[i] || pP.cap[i]) { > /* Cannot represent w/ legacy structure */ > return -ERANGE; >
Well, something went wrong with the patch - it has extra negative signs in my mail reader, and on lkml, but now that I've hit reply and it's been quoted, it looks fine in my mail client. So I have no idea what went on.
However, I got around the problem by making the code change manually - and my network connection is now working. Looking at the code being bypassed:
if (pE.cap[i] || pP.cap[i] || pP.cap[i])
looks somewhat weird as it is testing the same condition twice. Should it have been:
if (pE.cap[i] || pP.cap[i] || pI.cap[i]) ?
I'm about to test that change instead of bypassing the loop, so I'll let you know the results.
- -- Kevin Winchester
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHP4xGKPGFQbiQ3tQRAooWAJ9c6exhOiD4VUZ04hS9z77/RmERUACfauTE BV/JAexzlm2zSmG4laYi+HQ= =IPkA -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |