Messages in this thread | | | Date | Sat, 17 Nov 2007 10:27:20 -0800 | From | Andrew Morton <> | Subject | Re: [patch] Printk kernel version in WARN_ON |
| |
On Sat, 17 Nov 2007 10:15:52 -0800 Arjan van de Ven <arjan@infradead.org> wrote:
> @@ -35,8 +36,8 @@ struct bug_entry { > #define WARN_ON(condition) ({ \ > int __ret_warn_on = !!(condition); \ > if (unlikely(__ret_warn_on)) { \ > - printk("WARNING: at %s:%d %s()\n", __FILE__, \ > - __LINE__, __FUNCTION__); \ > + printk("WARNING: at %s:%d %s() (%s)\n", __FILE__, \ > + __LINE__, __FUNCTION__, UTS_RELEASE); \ > dump_stack(); \ > } \ > unlikely(__ret_warn_on); \
that made our 1100-odd WARN_ON sites fatter.
I suppose sometime we should optimise WARN_ON like we did BUG_ON. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |