Messages in this thread | | | Date | Fri, 16 Nov 2007 17:52:48 +0100 | From | Rene Herman <> | Subject | Re: [PATCH]: PNP: Increase the value of PNP constant |
| |
On 16-11-07 08:39, Zhao Yakui wrote:
> Subject: PNP: Increase the value of PNP constant > From: Zhao Yakui <yakui.zhao@intel.com> > > On some systems the number of resources(IO,MEM) returnedy by PNP > device is greater than the PNP constant, for example motherboard devices. > It brings that some resources can't be reserved and resource confilicts. > This will cause PCI resources are assigned wrongly in some systems, and > cause hang. This is a regression since we deleted ACPI motherboard > driver and use PNP system driver. > > Andrew, I thought this is an urgent issue and should be fixed ASAP, and > this is a good candidate for -stable tree > > Signed-off-by: Li Shaohua <shaohua.li@intel.com> > Signed-off-by: Zhao Yakui <yakui.zhao@intel.com> > > --- > drivers/pnp/pnpacpi/rsparser.c | 18 ++++++++++++++++-- > include/linux/pnp.h | 4 ++-- > 2 files changed, 18 insertions(+), 4 deletions(-) > > Index: linux-2.6.24-rc2/include/linux/pnp.h > =================================================================== > --- linux-2.6.24-rc2.orig/include/linux/pnp.h > +++ linux-2.6.24-rc2/include/linux/pnp.h > @@ -13,8 +13,8 @@ > #include <linux/errno.h> > #include <linux/mod_devicetable.h> > > -#define PNP_MAX_PORT 8 > -#define PNP_MAX_MEM 4 > +#define PNP_MAX_PORT 24 > +#define PNP_MAX_MEM 12
This fairly significantly grows (for example?) a struct pnp_resource_table. Are 24 and 12 really sensible?
Rene. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |