lkml.org 
[lkml]   [2007]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] keyspan: init termios properly
    On Thu, Nov 15, 2007 at 09:49:22AM -0800, Lucy McCoy wrote:
    > Greg & Boris,
    >
    > I've been out of town and just saw this.
    >
    > This patch will work with the 19HS but WILL BREAK all other Keyspan
    > adapters. It will take me a few days to get to looking at a correct fix but
    > that keyspan_send_setup(port, 1) (and the '1' is the important part) must
    > happen once
    > when the port is first opened. The cflag can just be set to whatever the
    > normal default
    > is for your serial environment. What are the defaults?

    Hi Lucy,

    sorry but i don't have the other usb-to-serial models to test them too, i guess
    you're in the position to do that :) Well, from what i've unterstood from
    reading the code, you can still do the keyspan_send_setup() call since the
    switch-case-statement is not handling the 19s series so while this call won't have any
    influence on them, it'll still init the others properly, no? Anyway, you can send me your
    fix for testing.

    Thanks.

    --
    Regards/Gruß,
    Boris.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-15 21:43    [W:3.913 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site