lkml.org 
[lkml]   [2007]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ipconfig.c : implement DHCP Class-identifier
Rainer Jochem wrote:
> Corrected version below.
>
>>> + printk(KERN_INFO "Sending class identifier \"%s\"\n",
>>> + vendor_class_identifier);
>> Seems like useless noise.
>
> This information is only sent in the case that the option is actually used.
> And in this case it might be useful for the user to see to which string the
> option was set.


I don't think its very useful since you can simply get this information
from /proc/cmdline in case something goes wrong, but if you insist at
least give it a meaningful prefix.

> @@ -580,6 +582,7 @@ ic_dhcp_init_options(u8 *options)
> u8 mt = ((ic_servaddr == NONE)
> ? DHCPDISCOVER : DHCPREQUEST);
> u8 *e = options;
> + int len = 0;

The initialization is unnecessary.

> #ifdef IPCONFIG_DEBUG
> printk("DHCP: Sending message type %d\n", mt);
> @@ -620,6 +623,16 @@ ic_dhcp_init_options(u8 *options)
> *e++ = sizeof(ic_req_params);
> memcpy(e, ic_req_params, sizeof(ic_req_params));
> e += sizeof(ic_req_params);
> +
> + if (*vendor_class_identifier) {
> + printk(KERN_INFO "Sending class identifier \"%s\"\n",
> + vendor_class_identifier);
> + *e++ = 60; /* Class-identifier */
> + len = strlen(vendor_class_identifier);
> + *e++ = len;
> + memcpy(e, vendor_class_identifier, len);
> + e += len;
> + }
> }
>
> *e++ = 255; /* End of the list */
> @@ -1507,5 +1520,16 @@ static int __init nfsaddrs_config_setup(
> return ip_auto_config_setup(addrs);
> }
>
> +static int __init vendor_class_identifier_setup(char *addrs)
> +{
> + if (strlcpy(vendor_class_identifier, addrs,
> + sizeof(vendor_class_identifier))
> + > sizeof(vendor_class_identifier))
> + printk(KERN_WARNING "vendorclass too long, truncated to \"%s\"",
> + vendor_class_identifier);

Should be >= I think.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-14 09:59    [W:1.207 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site