Messages in this thread | | | Date | Thu, 15 Nov 2007 13:08:00 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH] ata_sg_setup_one vs ata_sg_setup? |
| |
Rusty Russell wrote: > Hi Jeff, > > Was looking through libata, and it seems to me that ata_sg_setup is a > superset of ata_sg_setup_one. Am I missing something? Seems like it could > be simplified. > > My machine never seems to do an ata_sg_setup_one, so this patch isn't really > tested...
I have about the same patch queued here which also kills ata_sg_init_one() completely and replaces ATA_QCFLAG_SG/ATA_QCFLAG_SINGLE with ATA_QCFLAG_DMAMAP (now a single flag). I'll compare your version and mine and see if mine is missing something.
Thanks.
-- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |