Messages in this thread | | | Date | Wed, 14 Nov 2007 13:08:38 -0500 | Subject | Re: 2.6.24-rc2 XFS nfsd hang | From | "J. Bruce Fields" <> |
| |
On Wed, Nov 14, 2007 at 06:02:41PM +0000, Christoph Hellwig wrote: > On Wed, Nov 14, 2007 at 12:53:22PM -0500, J. Bruce Fields wrote: > > On Wed, Nov 14, 2007 at 05:44:19PM +0000, Christoph Hellwig wrote: > > > On Wed, Nov 14, 2007 at 12:39:22PM -0500, J. Bruce Fields wrote: > > > > This must have come up before; feel free to remind me: is there any way > > > > to make the interface easier to use? (E.g. would it help if the filldir > > > > callback could be passed a dentry?) > > > > > > The best thing for the filesystem would be to have a readdirplus > > > (or have it folded into readdir) instead of calling into lookup > > > from ->filldir. > > > > And the readdirplus would pass a dentry to its equivalent of ->filldir? > > Or something else? > > Personally I'd prefer it to only grow a struct stat or rather it's members > But the nfsd code currently expects a dentry so this might require some > major refactoring.
Well, we need to check for mountpoints, for example, so I don't see any way out of needing a dentry. What's the drawback?
--b. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |