Messages in this thread | | | Date | Tue, 13 Nov 2007 09:36:42 -0200 | From | Glauber de Oliveira Costa <> | Subject | Re: [PATCH 24/24] make vsmp a paravirt client |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Andi Kleen escreveu: > On Fri, Nov 09, 2007 at 04:43:05PM -0200, Glauber de Oliveira Costa wrote: >> This patch makes vsmp a paravirt client. It now uses the whole >> infrastructure provided by pvops. When we detect we're running >> a vsmp box, we change the irq-related paravirt operations (and so, >> it have to happen quite early), and the patching function > > The PARAVIRT ifdefs look wrong. Surely you don't need them at all > because it cannot work at all without paravirt.
The vsmp_64.c file is now compiled unconditionally, according to which me and kiran agreed to. The detection code is always run, but will only trigger when a suitable box is found. Accordingly, the paravirt structs are only touched when PARAVIRT is on. Otherwise, we don't even have the symbols.
> Also you got some white space damage.
Thanks, will fix.
> And the "EM64T based comment" is wrong because there are AMD based > vSMPs too. Just got it as-is from the old Kconfig. Do you think it should be fixed as well?
> -Andi
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Remi - http://enigmail.mozdev.org
iD8DBQFHOYxKjYI8LaFUWXMRApS3AJwJSYjW4Lw3dnPR4yMNfXABnMoQQQCcDMnf 3wBQoPjGO/8HO1Os4Y21vIU= =S+KO -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |