Messages in this thread | | | From | Herbert Xu <> | Subject | Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode | Date | Tue, 13 Nov 2007 19:09:23 +0800 |
| |
Patrick McHardy <kaber@trash.net> wrote: > > I still think promiscous mode should disable all filters (which would > also provide a consistent view between accerlated and non-accerlated > devices), but an ethtool option is better than nothing :)
I agree. People doing a tcpdump don't have to turn on promiscuous mode, that's what the -p option is for. In other words, having promiscuous mode disable VLAN filtering does not take away the user's options at all.
In fact, the very definition of promiscuous is to turn off hardware filtering, albeit the filtering of MAC addresses rather than VLAN tags. So it would seem logical to have it turn off VLAN filtering too.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |