Messages in this thread | | | Date | Tue, 13 Nov 2007 10:49:25 -0800 | From | Ravikiran Thirumalai <> | Subject | Re: [PATCH 24/24] make vsmp a paravirt client |
| |
On Tue, Nov 13, 2007 at 02:09:41PM +0100, Andi Kleen wrote: > >> If vsmp is selected, PARAVIRT will be too, and the interrupt code will >> be patched. >> the vsmp option triggers a select statement. >> >> the ifdef only exists because, as I said, the code itself will be always >> compiled in, to avoid an ifdef in setup_64.c. So it's just a taking it >> from here, putting it there issue. > >Peeking around needlessly in pci config space at each boot just to avoid an >ifdef is not an good idea.
Agreed. vsmp_init does not make sense unless the irq ops are patched. We can call vsmp_init under #ifdef CONFIG_PARAVIRT.
Thanks, Kiran - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |