Messages in this thread | | | From | Neil Brown <> | Date | Tue, 13 Nov 2007 09:08:42 +1100 | Subject | Re: nfsd bugfixes |
| |
On Monday November 12, bfields@citi.umich.edu wrote: > The following two patches are nfsd bugfixes that I believe are > appropriate for 2.6.24 and 2.6.23.y. > > --b. >
Both Reviewed-By: NeilBrown <neilb@suse.de>
Calling nfsd_setuser an extra time does open us up for a very tiny possibility of an ENOMEM at an awkward time. We could remove that entirely for NFSEXP_ALLSQUASH by allocating an empty group_info at export time and just using a reference to that. It would be more awkward to pre-allocate for the NFSEXP_ROOTSQUASH case as the group_info has to be at least as big as the one in the RPC request, and would could need a different one of each concurrent request.... not sure if that is worth "fixing".
Thanks, NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |