Messages in this thread | | | Date | Thu, 1 Nov 2007 19:59:57 +0100 | From | "Kay Sievers" <> | Subject | Re: [PATCH] [sysfs]: make readlink result shorter when the symlink and its target shared some base sysfs subdirectory |
| |
On Oct 31, 2007 3:34 PM, Greg KH <gregkh@suse.de> wrote: > On Wed, Oct 31, 2007 at 06:34:20PM +0800, Denis Cheng wrote: > > this is especially useful after /sys/slab introduced, for example: > > > > $ ls -l /sys/slab/mm_struct > > lrwxrwxrwx 1 root root 0 2007-10-31 17:40 /sys/slab/mm_struct -> :0000448 > > > > instead of: > > > > $ ls -l /sys/slab/mm_struct > > lrwxrwxrwx 1 root root 0 2007-10-31 17:40 /sys/slab/mm_struct -> ../slab/:0000448 > > > > Signed-off-by: Denis Cheng <crquan@gmail.com> > > As pretty as this change is, it's not really necessary, right? > > Is there any other place in /sys that would benefit from this?
Yeah: ep_81 -> ../../../../../devices/pci0000:00/0000:00:1d.0/usb2/2-0:1.0/usb_endpoint/usbdev2.1_ep81
just becomes: ep_81 -> usb_endpoint/usbdev1.1_ep81
which is nice. The current logic always goes back down to the root of sysfs and moves forward to the target, which in this case prepends the pointless: "../../../../../devices/pci0000:00/0000:00:1d.0/usb2/2-0:1.0/" to the target string.
Kay - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |