Messages in this thread | | | Subject | RE: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) to u8 | Date | Thu, 1 Nov 2007 09:11:32 -0400 | From | "Salyzyn, Mark" <> |
| |
ACK v2
Sincerely -- Mark Salyzyn
> -----Original Message----- > From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] > Sent: Thursday, November 01, 2007 2:32 AM > To: AACRAID > Cc: linux-scsi@vger.kernel.org; LKML > Subject: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) to u8 > > Noticed on PowerPC allmod config build: > > drivers/scsi/aacraid/commsup.c:1342: warning: large integer > implicitly truncated to unsigned type > drivers/scsi/aacraid/commsup.c:1343: warning: large integer > implicitly truncated to unsigned type > drivers/scsi/aacraid/commsup.c:1344: warning: large integer > implicitly truncated to unsigned type > > Also fix some whitespace on the changed lines. > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > --- > drivers/scsi/aacraid/commsup.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > This version just fixes a couple of whitespace anomolies on > the lines I > changed. > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > > diff --git a/drivers/scsi/aacraid/commsup.c > b/drivers/scsi/aacraid/commsup.c > index 240a0bb..3c2dbc0 100644 > --- a/drivers/scsi/aacraid/commsup.c > +++ b/drivers/scsi/aacraid/commsup.c > @@ -1339,9 +1339,9 @@ int aac_check_health(struct aac_dev * aac) > aif = (struct aac_aifcmd *)hw_fib->data; > aif->command = cpu_to_le32(AifCmdEventNotify); > aif->seqnum = cpu_to_le32(0xFFFFFFFF); > - aif->data[0] = cpu_to_le32(AifEnExpEvent); > - aif->data[1] = cpu_to_le32(AifExeFirmwarePanic); > - aif->data[2] = cpu_to_le32(AifHighPriority); > + aif->data[0] = AifEnExpEvent; > + aif->data[1] = AifExeFirmwarePanic; > + aif->data[2] = AifHighPriority; > aif->data[3] = cpu_to_le32(BlinkLED); > > /* > -- > 1.5.3.4 > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |