Messages in this thread | | | Date | Sun, 07 Oct 2007 23:04:07 -0700 (PDT) | Subject | Re: [patch 0/9] compat_ioctl: introduce block/compat_ioctl.c | From | David Miller <> |
| |
From: Al Viro <viro@ftp.linux.org.uk> Date: Mon, 8 Oct 2007 06:12:18 +0100
> On Sat, Oct 06, 2007 at 08:19:02PM +0200, Arnd Bergmann wrote: > > This is my block ioctl series split up into managable chunks. I'm not > > really sure about the last two of these, I'd prefer to get a second > > opinion on those. > > > > Please apply once your tests have gone though. > > BTW, one note: 0x1260 thing ( > /* The mkswap binary hard codes it to Intel value :-((( */ > case 0x1260: > case BLKGETSIZE: > ) is an ancient piece of BS. It had appeared in 2.1.115-pre3 and AFAICS > it's a misunderstanding. ... > IOW, that stuff is useless and always had been. In the current form it's > simply invalid C on e.g. amd64 - you get duplicate case there, which breaks > the build. > > I'd simply kill that.
Agreed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |