Messages in this thread Patch in this message | | | From | Rob Landley <> | Subject | Re: [RFC][PATCH] New message-logging API (kprint) | Date | Sun, 7 Oct 2007 16:50:49 -0500 |
| |
On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: > On 10/5/07, Rob Landley <rob@landley.net> wrote: > > The original idea (selectively compile out printk() instances based on > > log level to conserve space) is explicitly not addressed by this patch, > > and in fact this patch might actually make it harder to implement (by > > complicating the code). > > This is wrong. The patch provides log-level-based filtering at compile > time, effectively making the kernel smaller.
I made it about halfway through the patch and the only compile time filtering I found was:
--- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -62,7 +62,10 @@ #define MdpMinorShift 6 #define DEBUG 0 -#define dprintk(x...) ((void)(DEBUG && printk(x))) +#define dprintk(x...) \ + if(DEBUG) { \ + printk(x); \ + }
If you say it does, I'll take your word for it, but there's so much churn in there I didn't find it before my interest ran out...
Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |