lkml.org 
[lkml]   [2007]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Cute feature: colored printk output

* Jan Engelhardt <jengelh@computergmbh.de> wrote:

> Colored kernel message output
>
> Let's work more on Linux's cuteness!
> [http://lkml.org/lkml/2007/10/4/431] The following patch makes it
> possible to give kernel messages a selectable color which helps to
> distinguish it from other noise, such as boot messages. NetBSD has it,
> OpenBSD has it, FreeBSD to some extent, so I think Linux should too.
>
> Inspired by cko (http://freshmeat.net/p/cko/), but independently
> written, later contributed forth and back.
>
> Already posted at: http://lkml.org/lkml/2007/4/1/162
>
> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>

looks really good to me!

Reviewed-by: Ingo Molnar <mingo@elte.hu>

small nit:

+ vc->vc_color = printk_color;
+ update_attr(vc);

that should be in a set_vc_color() function and the new code should do:

+ set_vc_color(vc, vc->vc_color);

(and same at the other places that call update_attr() as well)

feature request: would be interesting to have a color table (defined in
the .config) dependent on message loglevel. That way KERN_CRIT messages
could be red, KERN_INFO ones white, etc.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-06 13:11    [W:0.349 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site