Messages in this thread | | | Subject | Re: [PATCH] [RFC] Time-based RFC 4122 UUID generator | From | Valdis.Kletnieks@vt ... | Date | Sat, 06 Oct 2007 23:42:10 -0400 |
| |
On Sat, 06 Oct 2007 15:53:37 +0200, Helge Deller said:
> diff --git a/drivers/char/random.c b/drivers/char/random.c > index af274e5..c84a385 100644 > --- a/drivers/char/random.c > +++ b/drivers/char/random.c > @@ -239,6 +239,7 @@ > #include <linux/spinlock.h> > #include <linux/percpu.h> > #include <linux/cryptohash.h> > +#include <linux/netdevice.h> > > #include <asm/processor.h> > #include <asm/uaccess.h> > @@ -1157,6 +1158,8 @@ void generate_random_uuid(unsigned char uuid_out[16]) > uuid_out[6] = (uuid_out[6] & 0x0F) | 0x40; > /* Set the UUID variant to DCE */ > uuid_out[8] = (uuid_out[8] & 0x3F) | 0x80; > + /* Set multicast bit to avoid conflicts with NIC MAC addresses */ > + uuid_out[10] |= 0x80; > }
Erm, was it *intended* that you also changed the behavior of generate_random_uuid()?
[unhandled content-type:application/pgp-signature] | |