Messages in this thread | | | Date | Sat, 6 Oct 2007 14:41:57 -0700 | From | Paul Jackson <> | Subject | Re: [PATCH] task containersv11 add tasks file interface fix for cpusets |
| |
Paul M wrote: > > What's wrong with: > > allocate a page of task_struct pointers > again: > need_repeat = false; > cgroup_iter_start(); > while (cgroup_iter_next()) { > if (p->cpus_allowed != new_cpumask) { > store p; > if (page is full) { > need_repeat = true; > break; > } > } > } > for each saved task p { > set_cpus_allowed(p, new_cpumask); > release p; > } > if (need_repeat) > goto again;
That might work ... nice idea there, comparing the two masks, so one only needs to store the ones not yet fixed. Uunfortunately, I need to put this aside until I return in four days, from a short trip.
Given that cgroups is targeted for 2.6.24, and that cpusets is broken without this, I'll have to do something soon. But this, or some such, should work, soon enough.
Thanks.
> I'd much rather not perpetuate that broken API requirement. The fact > that cpusets wants this odd behaviour is based on a nasty hack.
Well ... yeah ... it's a bit of an ugly child. But I'm its daddy. The kid looks fine in my eyes. <grin>
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |