lkml.org 
[lkml]   [2007]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend] Make the dev_*() family of macros in device.hcomplete
On Tue, Oct 30, 2007 at 05:11:24AM -0700, Medve Emilian-EMMEDVE1 wrote:
> Hi Greg K-H,
>
>
> > > +#define dev_info(dev, format, arg...) \
> > > + dev_printk(KERN_INFO, dev, format, ## arg)
> > > +
> > > #ifdef DEBUG
> > > #define dev_dbg(dev, format, arg...) \
> > > - dev_printk(KERN_DEBUG , dev , format , ## arg)
> > > + dev_printk(KERN_DEBUG, dev, format, ## arg)
> >
> > Those extra spaces are there for a good reason, older versions of gcc
> > are broken without it. So please, put them all back...
>
> You mean I should add spaces before commas only where they were
> initially or to all new code and/or macros?

Put it back where it was, and do the same for all other macros.

> I've observed other kernel code and more often there are no spaces
> before commas. I'm asking because the CodingStyle document is not very
> explicit about this rule.

This is a gcc rule, for variable length macros, not a CodingStyle
guideline. It just will not work without it :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-30 16:43    [W:0.143 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site