Messages in this thread | | | Date | Tue, 30 Oct 2007 09:59:32 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls |
| |
> +static int __ioctl_fibmap(struct file *filp, int __user *p)
I'd say kill the __ prefix for all the functions you're adding.
> +static int __ioctl_fionbio(struct file *filp, unsigned long arg)
> +static int __ioctl_fioasync(unsigned int fd, struct file *filp, > + unsigned long arg)
For these two I'd add a
void __user *argp = (void __user *)arg;
in the caller and then just pass argp down. That way we have the cast in one place.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |