lkml.org 
[lkml]   [2007]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [linux-usb-devel] USB HCD: avoid duplicate local_irq_disable()
    On Thu, 25 Oct 2007, Greg KH wrote:

    > On Tue, Oct 23, 2007 at 12:01:37AM -0400, Alan Stern wrote:
    > > On Tue, 23 Oct 2007, Arnd Bergmann wrote:
    > >
    > > > usb_hcd_flush_endpoint() has a retry loop that starts with a spin_lock_irq(),
    > > > but only gives up the spinlock, not the irq_disable before jumping to the
    > > > rescan label.
    > > >
    > > > Split the spin_lock_irq into the retryable part and the local_irq_disable()
    > > > that is only done once as a micro-optimization and slight cleanup.
    > >
    > > I agree with your sentiment, but it would be better to solve this
    > > problem without using local_irq_disable(). The patch below does this.
    > >
    > > ---
    > >
    > > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
    >
    > Alan, is this something you want added to the tree and in before 2.6.24
    > is out?

    Yes. It's a small thing, but we're better off keeping IRQ
    enable/disable calls properly balanced.

    Alan Stern

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-27 21:17    [W:4.175 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site