Messages in this thread | | | Date | Fri, 26 Oct 2007 03:19:50 +0200 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] kernel/cgroup.c: remove dead code |
| |
On Thu, Oct 25, 2007 at 06:10:24PM -0700, Paul Menage wrote: > On 10/24/07, Paul Jackson <pj@sgi.com> wrote: > > Paul M wrote: > > > I think I'd rather not make this change - if we later changed the size > > > of release_agent_path[] this could silently fail. Can we get around > > > the coverity checker somehow? > > > > Perhaps we can simplify this check then, to: > > > > BUG_ON(sizeof(cgrp->root->release_agent_path) < PATH_MAX)); > > > > Less runtime code. > > Sounds reasonable to me. Is there any kind of compile-time assert > macro in the kernel?
BUILD_BUG_ON()
> Paul
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |