Messages in this thread | | | Date | Thu, 25 Oct 2007 17:20:25 -0700 | From | Zach Brown <> | Subject | Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5] |
| |
Roland Dreier wrote: > > > +static inline void *ERR_CAST(const void *ptr) > > > +{ > > > + return (void *) ptr; > > > +} > > > > Just to nit, surely you don't need the cast inside the function. The > > casting happens at the call site between the argument and returned pointer. > > The way it's written you kinda do, since it takes a const void * and > returns a plain void *.
Ah, right, I missed that.
- z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |