Messages in this thread | | | Subject | Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend) | From | Richard Purdie <> | Date | Thu, 25 Oct 2007 22:47:25 +0100 |
| |
On Thu, 2007-10-25 at 23:35 +0200, Ingo Oeser wrote: > On Thursday 25 October 2007, Kristen Carlson Accardi wrote: > > Enable enclosure management via LED > > > > As described in the AHCI spec, some AHCI controllers may support > > Enclosure management via a variety of protocols. This patch > > adds support for the LED message type that is specified in > > AHCI 1.1 and higher. > > Linux has a LED subsystem for that. May I suggest, that you just register > these leds and let userspace handle them via that via the LED API? > > The LED userspace API is described in Documentation/leds-class.txt > and the headers for registering LEDs is linux/leds.h under include/ > > Since you explicitly WANT user space to control these, that should > be the right API. > > Richard, what do YOU think?
If you're exporting LEDs to userspace, the LED API was designed to do just that...
Cheers,
Richard
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |